Java敏捷开发技巧之消除代码异味(1)

class Shape {   
final static int TYPELINE = 0;   
final static int TYPERECTANGLE = 1; 
final static int TYPECIRCLE = 2; 
int shapeType;   
//线条的开始点
//长方形左下角的点
//圆心
Point p1;
//线条的结束点
//长方形的右上角的点
//如果是圆的话,这个属性不用
Point p2;
int radius;  
}   
class CADApp {  
void drawShapes(Graphics graphics, Shape shapes[]) { 
for (int i = 0; i < shapes.length; i++) {
switch (shapes[i].getType()) {   
case Shape.TYPELINE:  
graphics.drawLine(shapes[i].getP1(), shapes[i].getP2());  
break;
case Shape.TYPERECTANGLE: 
//画四条边
graphics.drawLine(...);   
graphics.drawLine(...);   
graphics.drawLine(...);   
graphics.drawLine(...);   
break;
case Shape.TYPECIRCLE:
graphics.drawCircle(shapes[i].getP1(), shapes[i].getRadius());
break;
}
}
}
}   

class Shape {  
final static int TYPELINE = 0;
final static int TYPERECTANGLE = 1;
final static int TYPECIRCLE = 2;
final static int TYPETRIANGLE = 3;
int shapeType;  
Point p1;   
Point p2;   
//三角形的第三个点.
Point p3;   
int radius; 
}  
class CADApp { 
void drawShapes(Graphics graphics, Shape shapes[]) {
for (int i = 0; i < shapes.length; i++) {
switch (shapes[i].getType()) {
case Shape.TYPELINE:
graphics.drawLine(shapes[i].getP1(), shapes[i].getP2());
break;
case Shape.TYPERECTANGLE:
//画四条边.
graphics.drawLine(...);
graphics.drawLine(...);
graphics.drawLine(...);
graphics.drawLine(...);
break;
case Shape.TYPECIRCLE:
graphics.drawCircle(shapes[i].getP1(), shapes[i].getRadius());
break;
case Shape.TYPETRIANGLE:
graphics.drawLine(shapes[i].getP1(), shapes[i].getP2());
graphics.drawLine(shapes[i].getP2(), shapes[i].getP3());
graphics.drawLine(shapes[i].getP3(), shapes[i].getP1());
break;
}   
}   
}   
}